Bugfix/154 colorstate comparison fails when comparing with null values#155
Open
DivineThreepwood wants to merge 22 commits intodevfrom
Open
Bugfix/154 colorstate comparison fails when comparing with null values#155DivineThreepwood wants to merge 22 commits intodevfrom
DivineThreepwood wants to merge 22 commits intodevfrom
Conversation
✅ Deploy Preview for basecubeone canceled.
|
DivineThreepwood
added
the
preview
lhuxohl
requested changes
Feb 19, 2026
...src/main/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderService.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderService.java
Outdated
Show resolved
Hide resolved
...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt
Show resolved
Hide resolved
...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt
Outdated
Show resolved
Hide resolved
...c/test/java/org/openbase/bco/dal/lib/layer/service/provider/ColorStateProviderServiceTest.kt
Show resolved
Hide resolved
DivineThreepwood
removed
the
preview
lhuxohl
previously approved these changes
Mar 10, 2026
lhuxohl
previously approved these changes
Mar 18, 2026
lhuxohl
requested changes
Apr 1, 2026
| try { | ||
| if (getActionDescription().getIntermediary()) { | ||
| for (final RemoteAction impactedRemoteAction : impactedRemoteActions) { | ||
| for (final RemoteAction impactedRemoteAction : impactedRemoteActions.stream().toList()) { |
Contributor
There was a problem hiding this comment.
Why is this ported to a stream and then to a list?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Changes proposed in this pull request:
✅ Checklist: